v1 reflection: Bail out early for required configs not passed #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deve-sh
commented
Nov 3, 2025
Comment on lines
+60
to
+69
| if (!url) { | ||
| throw new Error('Error: url is required for server reflection'); | ||
| } | ||
|
|
||
| if (!credentials) { | ||
| throw new Error( | ||
| 'Error: credentials parameter is required for server reflection' | ||
| ); | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Why not have this error handled and caught in the supported API evaluation function? Because we want the consumer of this library to know even before they reach the stage of calling the reflection API.
If the constructor crashes at initialization, hence notifying the consumer of the problem in their implementation. The listServices function will never be invoked in the first place.
This mimics the behaviour we had earlier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.